Re: binary mode copies

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 3/15/2005 3:47 PM:
>>>
>>>2005-03-15  Corinna Vinschen  <address@hidden>  (tiny change)
>>>
>>>     * src/copy.c (copy_reg): Copy regular files in binary mode.
> 
> 
> By the way, can you produce a small test case that fails
> without this patch and that succeeds with it?
> Best would be a patch adding a test to be run by `make check'.
> 

I'll see what I can come up with.  It only fails on cygwin when
directories are mounted as text mode, rather than binary mode; but to date
I've always run the testsuite on a binary mode mount.  I'll have to run
the tests from a text mount point, and see what other problems it
uncovers.  A test should be a simple as verifying file sizes after copying
two files, one with \n and the other with \r\n line endings.

My biggest obstacle now is that I still don't have my employer's signature
permitting me to contribute to FSF.  Otherwise, I already have several
other testsuite improvements lined up for contribution.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCN5Fx84KuGfSFAYARAvE0AJoDxeKTwIHJmPMiHtqrj6frc0iwggCgmCGk
D+On4fWqCilvgTJbXVA3Rfg=
=bfft
-----END PGP SIGNATURE-----