Re: coreutils readutmp applies strchr to a non-string

[Paul Eggert]

address@hidden (Paul Jarc) writes:

> Paul Eggert <address@hidden> wrote:
>> coreutils readutmp applies strchr to a buffer that is not
>> null-terminated.
>
> Would this work?  It seems like the simplest fix.
>
> -  p = strchr (trimmed_name, ' ');
> +  p = memchr (trimmed_name, ' ', sizeof (UT_USER (ut)) + 1);

Yes, that's a simpler fix, but it still doesn't make the code match
the comments.  The comments say 'trim trailing spaces' but the above
code trims non-spaces if they are preceded by a space.