Re: signal-handling cleanup for csplit, install, ls, nohup, sort, tee

[Jim Meyering]

Paul Eggert <address@hidden> wrote:
> 2004-04-18  Paul Eggert  <address@hidden>
...
>        - install -s failed on System V if SIGCHLD was ignored.
...
>       * src/install.c: Include <signal.h>.
>       (main) [defined SIGCHLD]: Ignore SIGCHLD if -s is given, since
>       System V fork+wait does not work if SIGCHLD is ignored.
...
> Index: src/install.c
> ===================================================================
> RCS file: /home/meyering/coreutils/cu/src/install.c,v
> retrieving revision 1.158
> diff -p -u -r1.158 install.c
> --- src/install.c     7 Feb 2004 16:01:31 -0000       1.158
> +++ src/install.c     15 Apr 2004 05:06:06 -0000
...
> @@ -227,6 +228,10 @@ main (int argc, char **argv)
>         break;
>       case 's':
>         strip_files = 1;
> +#ifdef SIGCHLD
> +       /* System V fork+wait does not work if SIGCHLD is ignored.  */
> +       signal (SIGCHLD, SIG_DFL);
> +#endif
>         break;
>       case 'd':
>         dir_arg = 1;

Thanks!
Should the above ChangeLog entry say this instead?

        * src/install.c: Include <signal.h>.
        (main) [defined SIGCHLD]: Set SIGCHLD handler to the default,
        if -s is given, since System V fork+wait does not work if SIGCHLD
        is ignored.