Re: patching dd

[Jim Meyering]

Olivier Delhomme <address@hidden> wrote:
> I send a patch on november 2 and i was wondering if
> it was sent directly to /dev/null ?

You sent it to the right place.
But sometimes it takes a long time for me to handle feature additions.

> Please let me know, where i am wrong with this patch
> as it adds a feature requested in the TODO list :
>
> dd: consider adding an option to suppress `bytes/block read/written'
> output to stderr.  Suggested here:
>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=165045
>
> Learning is the best way to increase knowledge, please let me know !

I looked at your patch.
One of the first steps was to apply it to my working sources.
That failed:

  $ patch < /tmp/k
  patching file dd.c
  patch: **** malformed patch at line 163: 234M)\n\+  si             likewise, 
but uses powers of 1000 instead of

because your mail client word-wrapped the message,
making the diff nearly useless.

Please resend the patch without mangling long lines.