bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: coreutils-5.0.1: bug in kill


From: Jim Meyering
Subject: FYI: coreutils-5.0.1: bug in kill
Date: Wed, 16 Jul 2003 22:00:03 +0200

There's a pretty bad bug in kill.  Mea culpa.
This means that coreutils-5.0.2 (or maybe coreutils-5.0.90)
will be coming soon.

  $ sleep 9 & ./kill $!
  [2] 27983
  ./kill: ./kill: invalid process id
  [2]+  Terminated              sleep 20
  [Exit 1]

You'll notice that kill tried to kill the string `./kill' in
addition to the supplied process ID.

Here's the fix:

        * src/kill.c (main): Fix bug introduced on 2003-05-10 (for 5.0.1)
        whereby kill would always attempt to operate on argv[0] and fail.

Index: kill.c
===================================================================
RCS file: /fetish/cu/src/kill.c,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -p -u -r1.9 -r1.10
--- kill.c      17 Jun 2003 18:13:23 -0000      1.9
+++ kill.c      16 Jul 2003 19:42:34 -0000      1.10
@@ -373,5 +373,5 @@ main (int argc, char **argv)
 
   return (list
          ? list_signals (table, optind < argc ? argv + optind : NULL)
-         : send_signals (signum, argv));
+         : send_signals (signum, argv + optind));
 }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]