bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

A few more patches for coreutils 4.5.3


From: Petter Reinholdtsen
Subject: A few more patches for coreutils 4.5.3
Date: Tue Oct 22 10:48:02 2002

Here are a few patches for coreutils 4.5.3.  Some of them are required
to get the source compiling on AIX and Irix.

 - Fix email address in README to match the correct one.
 - The native AIX compiler will not accept 'bool' type on bit fields.
   Use unsigned int instead.
 - The prototype for memrchr() is missing on Irix and AIX when
   compiling tail.c.  Add it.  This patch should probably be moved to
   some .h file.  I was unable to find out which.

There are still some problems on AIX left.  It fail to link with the
following error:

  make[1]: Entering directory
    `/usit/hufflepuff/local/store/hufflepuff/coreutils-c/src-4.5.3-rs6aix5/src'
  cc-wrapper  -g   -o pathchk  pathchk.o ../lib/libfetish.a  ../lib/libfetish.a
  ld: 0711-317 ERROR: Undefined symbol: .pathconf_wrapper
  ld: 0711-345 Use the -bloadmap or -bnoquiet option to obtain more
    information.
  make[1]: Leaving directory
    `/usit/hufflepuff/local/store/hufflepuff/coreutils-c/src-4.5.3-rs6aix5/src'
  make[1]: *** [pathchk] Error 8
  make: *** [install-recursive] Error 1

diff -ur src-4.5.3/README src-4.5.3-local/README
--- src-4.5.3/README    2002-09-02 09:53:13.000000000 +0200
+++ src-4.5.3-local/README      2002-10-22 14:51:22.000000000 +0200
@@ -68,7 +68,7 @@

 If your patch adds a new feature, please try to get some sort of consensus
 that it is a worthwhile change.  One way to do that is to send mail to
address@hidden (aka the gnu.utils.bug news group) including as
address@hidden (aka the gnu.utils.bug news group) including as
 much description and justification as you can.  Based on the feedback
 that generates, you may be able to convince us that it's worth adding.

diff -ur src-4.5.3/src/fmt.c src-4.5.3-local/src/fmt.c
--- src-4.5.3/src/fmt.c 2002-09-24 10:50:20.000000000 +0200
+++ src-4.5.3-local/src/fmt.c   2002-10-21 19:41:17.000000000 +0200
@@ -134,10 +134,10 @@
     const char *text;          /* the text of the word */
     int length;                        /* length of this word */
     int space;                 /* the size of the following space */
-    bool paren:1;              /* starts with open paren */
-    bool period:1;             /* ends in [.?!])* */
-    bool punct:1;              /* ends in punctuation */
-    bool final:1;              /* end of sentence */
+    unsigned int paren:1;      /* starts with open paren */
+    unsigned int period:1;     /* ends in [.?!])* */
+    unsigned int punct:1;      /* ends in punctuation */
+    unsigned int final:1;      /* end of sentence */

     /* The remaining fields are computed during the optimization.  */

diff -ur src-4.5.3/src/pathchk.c src-4.5.3-local/src/pathchk.c
--- src-4.5.3/src/pathchk.c     2002-09-02 09:43:38.000000000 +0200
+++ src-4.5.3-local/src/pathchk.c       2002-10-21 19:41:17.000000000 +0200
@@ -66,7 +66,9 @@
 # endif /* not PATH_MAX */
 # ifndef NAME_MAX
 #  define NAME_MAX_FOR(p) pathconf_wrapper ((p), _PC_NAME_MAX);
-#  define NEED_PATHCONF_WRAPPER 1
+#  ifndef NEED_PATHCONF_WRAPPER
+#   define NEED_PATHCONF_WRAPPER 1
+#  endif
 # endif /* not NAME_MAX */

 #else
diff -ur src-4.5.3/src/tail.c src-4.5.3-local/src/tail.c
--- src-4.5.3/src/tail.c        2002-10-13 16:03:08.000000000 +0200
+++ src-4.5.3-local/src/tail.c  2002-10-22 14:16:36.000000000 +0200
@@ -42,6 +42,10 @@
 #include "xstrtol.h"
 #include "xstrtod.h"

+#if ! defined(HAVE_MEMRCHR) /* Needed on AIX and Irix */
+extern void *memrchr (const void *__s, int __c, size_t __n);
+#endif /* HAVE_MEMRCHR */
+
 /* The official name of this program (e.g., no `g' prefix).  */
 #define PROGRAM_NAME "tail"


In addition to these problems, there are a few bugs in the configure
rules.  This is from AIX 5.1:

  checking for getgroups... yes
  checking for working getgroups... yes
  ./configure[25552]: test: argument expected
  checking for _LARGEFILE_SOURCE value needed for large files... no

This is from Irix 6.5:

  checking for working getgroups... yes
  checking for _LARGEFILE_SOURCE value needed for large
    files... ./configure[25552]: test: argument expected
  no
  checking for fseeko... yes
  checking for vprintf... (cached) yes

This is from HP/UX 11.00:

  checking for working getgroups... yes
  checking for _LARGEFILE_SOURCE value needed for large
    files... ./configure[25552]: test: Specify a parameter with this
    command.
  1
  checking for fseeko... yes
  checking for vprintf... (cached) yes

I suspect the problem are some 'test $variable' needing quotes like
'test "$variable"'.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]