bug-commoncpp
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Patch for bug's in SocketPort and IOException


From: Prochnow, Christian
Subject: Patch for bug's in SocketPort and IOException
Date: Wed, 20 Nov 2002 12:30:37 +0100
User-agent: KMail/1.4.3

Hi List,

found some problems in recently added features:

in IOException::getSystemErrorString():
- _systemErrorString must only be allocated once.

- i thought "if ( NULL == _systemErrorString )" was not the intention of the 
programmer, instead it should be "if ( NULL != _systemErrorString )"

- in IOException::~IOException():
delete _systemErrorString - simply not right - array`s are deleted with
delete[] not with delete.

SocketPort connecting constructor:
- do not restore the O_NDLAY flag when ::connect() has failed!
 this caused the connectError() to store a zero error code cause the fcntl() 
after connect() succeeded :)

Regards,
Christian

-- 
Christian Prochnow
Berliner Freiverkehr (Aktien) AG - Kurfürstendamm 117 - 10711 Berlin, Germany
Fon: +49-30-89606409, Fax: +49-30-89021389 - EMail: address@hidden

Attachment: commoncpp2.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]