[bug-cflow] tokdel() patch and support for _many_ files

[Angebrand Niklas (2) (Consultant)]

Hi,

 

There seems to be a bug in cflow which causes a segmentation fault in certain scenarios when run in Windows. The issue seems to be with the tokdel() function in parser.c which has been solved by the commit below. See attached txt file for a brief description. You might want to consider bringing this or a similar patch into the main repository.

 

https://github.com/TriggerHappy/cflow-argfiles/commit/5876b5b1b1595d5fd9ca0eee2f7a54ef124fd466

 

The bug was only detected in Windows but my view is that it is also a bug when compiled for any other environment; it only shows that the memory protection rules seem to be different in Windows when compared to Linux. I tried with the following configurations:

 

uname from Linux:

Linux osboxes 4.4.0-21-generic #37-Ubuntu SMP Mon Apr 18 18:33:37 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

 

uname from Windows:

MSYS_NT-6.1 <hostname> 2.4.1(0.294/5/3) 2016-02-03 10:57 x86_64 Msys

 

For your curiosity, in the same repository on github but different branch you will find an implemented workaround when throwing a lot of files at cflow (e.g. so many that they exceed the maximum length of a command line). By putting the files you want to analyse into a white-space separated file and appointing that file with @<filename>, the list of files will be processed as usual by cflow.

 

Best regards,

Niklas Angebrand

 

tokdel-patch.txt
Description: tokdel-patch.txt