|
From: | Scott Lackey |
Subject: | Re: 2.1.19p1 misidentifies if server is VMWare ESX |
Date: | Fri, 10 Mar 2006 18:09:35 -0500 |
During testing of 2.1.19p1 I noticed that the class VMWare_ESX was defined
on a machine that was not an ESX image or server. Looking at misc.c, it
appears that if you can stat /etc/issue, cfengine defines the VMWare_ESX
class.
src/misc.c:
836 if (stat("/etc/issue",&statbuf) != -1)
837 {
838 Verbose("\nThis appears to be a VMWare ESX system.\n");
839 AddClassToHeap("VMWare_ESX");
840 ESX_version();
841 }
Shouldn't that be checking for the existence of the VMware-esx rpm, or the
existence of the /etc/vmware directory, and not relying on stat'ing
/etc/issue? We drop /etc/motd and /etc/issue files on every host that
print out a big warning banner.
If I need to provide more info please let me know.
Jamie
_______________________________________________
Bug-cfengine mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/bug-cfengine
[Prev in Thread] | Current Thread | [Next in Thread] |