Re: Bug in cfengine 2.1.7+ - segfaults when running cfagent with -v

[Mark . Burgess]

Thanks for the message. I'll look into it.

M

On 26 Jul, Geir Hauge wrote:
> There seems to be a bug introduced in version 2.1.7 of cfengine. On a
> solaris box I experienced that cfagent would randomly segfault when
> using the -v option. I never experienced any troubles when not using -v.
> The last line of output each time it segfaulted were always:
> 
> !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
> 
> Snooping around in the sourcecode, it appeared that it was the following
> section from install.c it segfaulted on:
> 
> if (ptr->purge == 'y' && strstr(ep->name,"localhost") == 0)
>    {
>    
> Verbose("!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n");   
>    
>    Verbose("!! Purge detected in local (non-cfd) file copy to file 
> %s\n",ptr->destination);
>    Verbose("!! Do not risk purge if source %s is NFS mounted (see 
> manual)\n",ptr->path);
>    Verbose("!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n");
>    }      
> 
> ptr->purge and ptr->destination isn't set yet!, ptr gets malloc'ed, but
> no new value is given to ptr->purge and so forth.
> 
> This problem is apparent in both 2.1.7p1 and 2.1.7 of cfengine. From
> 2.1.6 to 2.1.7 there's alot of changes to install.c and it appears that
> the code-section above should've appeared much later in the code. In
> 2.1.6 it appears _after_ ptr->purge and ptr->destination gets set and so
> forth. So, is the code-section above just misplaced? Not having gone
> deeper into the code, I can't be certain, so I'll leave that question
> for the author. :)
> 



~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Work: +47 22453272            Email:  address@hidden
Fax : +47 22453205            WWW  :  http://www.iu.hio.no/~mark
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~