Re: bug report - Solaris 10 on M4000 system

[Akim Demaille]

Hi Daniel,

Thanks for the report.  grep -q is not portable, sorry
this issue crept in the test suite.  I installed the following
in the maint branch.

From 0a244a2269aa09031bf3f92b68fbab4578beec74 Mon Sep 17 00:00:00 2001
From: Akim Demaille <address@hidden>
Date: Wed, 4 Sep 2013 17:23:37 +0200
Subject: [PATCH] tests: do not use grep -q

Reported by Daniel Galloway.
http://lists.gnu.org/archive/html/bug-bison/2013-08/msg00020.html

* tests/java.at: Ignore grep's output instead.
---
 NEWS          |  3 +++
 THANKS        |  1 +
 tests/java.at | 13 +++++++++----
 3 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/NEWS b/NEWS
index 07bf5a9..bbdcc0f 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,9 @@ GNU Bison NEWS
 
 * Noteworthy changes in release ?.? (????-??-??) [?]
 
+** Bug fixes
+
+  Portability issues in the test suite.
 
 * Noteworthy changes in release 3.0 (2013-07-25) [stable]
 
diff --git a/THANKS b/THANKS
index 321a8b8..2d4a6a9 100644
--- a/THANKS
+++ b/THANKS
@@ -31,6 +31,7 @@ Cris van Pelt             address@hidden
 Csaba Raduly              address@hidden
 Dagobert Michelsen        address@hidden
 Daniel Frużyński          address@hidden
+Daniel Galloway           address@hidden
 Daniel Hagerty            address@hidden
 David J. MacKenzie        address@hidden
 David Kastrup             address@hidden
diff --git a/tests/java.at b/tests/java.at
index 2b20698..58998fe 100644
--- a/tests/java.at
+++ b/tests/java.at
@@ -725,18 +725,23 @@ AT_CLEANUP
 
 AT_SETUP([Java constructor init and init_throws])
 
+m4_pushdef([AT_Witness],
+[super("Test Thread"); if (true) throw new InterruptedException();])
+
 AT_CHECK_JAVA_MINIMAL([[
 %define extends {Thread}
-%code init { super("Test Thread"); if (true) throw new InterruptedException(); 
}
+%code init { ]AT_Witness[ }
 %define init_throws {InterruptedException}
 %lex-param {int lex_param}]])
-AT_CHECK([[grep -q 'super("Test Thread"); if (true) throw new 
InterruptedException();' YYParser.java]])
+AT_CHECK([[grep ']AT_Witness[' YYParser.java]], 0, [ignore])
 
 AT_CHECK_JAVA_MINIMAL_W_LEXER([[
 %define extends {Thread}
-%code init { super("Test Thread"); if (true) throw new InterruptedException(); 
}
+%code init { ]AT_Witness[ }
 %define init_throws {InterruptedException}]], [], [[return EOF;]])
-AT_CHECK([[grep -q 'super("Test Thread"); if (true) throw new 
InterruptedException();' YYParser.java]])
+AT_CHECK([[grep ']AT_Witness[' YYParser.java]], 0, [ignore])
+
+m4_popdef([AT_Witness])
 
 AT_CLEANUP
 
-- 
1.8.4