[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [GNU Bison 2.5] testsuite: 3 4 7 8 16 21 33 36 45 68 69 70 92 93 94
From: |
Akim Demaille |
Subject: |
Re: [GNU Bison 2.5] testsuite: 3 4 7 8 16 21 33 36 45 68 69 70 92 93 94 95 139 143 145 151 160 220 221 222 228 233 246 failed |
Date: |
Tue, 13 Mar 2012 12:13:38 +0100 |
Le 6 mars 2012 à 09:21, Akim Demaille a écrit :
> I installed this in maint, and will install it in master
> when I'm done with the other pending patches.
>
> From c14ceb55b9dd1961a8e234dfd789b31d7763604a Mon Sep 17 00:00:00 2001
> From: Akim Demaille <address@hidden>
> Date: Tue, 6 Mar 2012 09:09:02 +0100
> Subject: [PATCH] tests: be robust to POSIXLY_CORRECT being defined.
>
> * tests/local.at (AT_BISON_CHECK_NO_XML): Check if
> POSIXLY_CORRECT is defined, not if it is defined to 1.
> Reported by Lie Yan.
> http://lists.gnu.org/archive/html/bug-bison/2012-03/msg00000.html
Was installed in both. I have also installed the following
patch in both master and maint. This should address all your
concerns.
From dd31e17d7e415d3be8fc603f752f7e975297bcc2 Mon Sep 17 00:00:00 2001
From: Akim Demaille <address@hidden>
Date: Wed, 22 Feb 2012 14:42:59 +0100
Subject: [PATCH 1/2] tests: minor fixes/simplifications
* tests/local.at (AT_BISON_CHECK_NO_XML): Simplify sed programs,
quotation, and default value assignments.
Ensure a proper value to the numeric variables.
Reported by Lie Yan.
http://lists.gnu.org/archive/html/bug-bison/2012-03/msg00000.html
---
tests/local.at | 22 +++++++++-------------
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/tests/local.at b/tests/local.at
index 57c2ae6..a8b3876 100644
--- a/tests/local.at
+++ b/tests/local.at
@@ -303,14 +303,12 @@ m4_if(m4_bregexp([$4], [: warning: ]), [-1], [],
# Build expected stderr up to and including the "warnings being
# treated as errors" message.
]AT_DATA([[at-bison-check-warnings]], [$4])[
- at_bison_check_first="` \
- sed -n '/: warning: /=' at-bison-check-warnings \
- | sed -n 1p \
- `"
- at_bison_check_first_tmp="` \
- sed -n '/conflicts: [0-9].*reduce$/=' at-bison-check-warnings \
- | sed -n 1p \
- `"
+ at_bison_check_first=`sed -n \
+ '/: warning: /{=;q;}' at-bison-check-warnings`
+ : ${at_bison_check_first:=1}
+ at_bison_check_first_tmp=`sed -n \
+ '/conflicts: [0-9].*reduce$/{=;q;}' at-bison-check-warnings`
+ : ${at_bison_check_first_tmp:=1}
if test $at_bison_check_first_tmp -lt $at_bison_check_first; then
at_bison_check_first=$at_bison_check_first_tmp
fi
@@ -324,11 +322,9 @@ m4_if(m4_bregexp([$4], [: warning: ]), [-1], [],
# complaints cause bison to exit early. Thus, with -Werror, bison
# does not necessarily report all warnings that it does without
# -Werror, but it at least reports one.
- at_bison_check_last="`sed -n '$=' stderr`"
- if test x"$at_bison_check_last" = x; then
- at_bison_check_last=1
- fi
- at_bison_check_last="`expr $at_bison_check_last - 1`"
+ at_bison_check_last=`sed -n '$=' stderr`
+ : ${at_bison_check_last:=1}
+ at_bison_check_last=`expr $at_bison_check_last - 1`
sed -n "$at_bison_check_first,$at_bison_check_last"p \
at-bison-check-warnings >> experr
]AT_CHECK([[sed 's,.*/\(]AT_BISON_WERROR_MSG[\)$,\1,' \
--
1.7.9.2