Re: [GNU Bison 2.4.1] testsuite: 51 failed (i686-cygwin)

[Joel E. Denny]

On Thu, 17 Sep 2009, Michael Raskin wrote:

>               Hello.
>        The test claims to create file with name 
> address@hidden&*()-=_+{}[]|\:;<>,
> .' . It looks like this simply shouldn't succeed on i686-cygwin platform
> because of ":" and "\". "/", which is directory separator on most
> platforms, is not included in the test file name. Should the test be
> corrected?

Thanks for the report.  To fix that, I pushed this to branch-2.4.2, 
branch-2.5, and master.

>From 2ceb8c617cac934b45f101ab44508d72239c894b Mon Sep 17 00:00:00 2001
From: Joel E. Denny <address@hidden>
Date: Sun, 4 Oct 2009 22:59:18 -0400
Subject: [PATCH] tests: skip tests of file names that platform does not support.

Reported by Michael Raskin at
<http://lists.gnu.org/archive/html/bug-bison/2009-09/msg00001.html>.
* THANKS (Michael Raskin): Add.
* tests/output.at (AT_CHECK_OUTPUT_FILE_NAME): Fix.  Cygwin used
to fail at least for file names containing ":" or "\".
---
 ChangeLog       |    9 +++++++++
 THANKS          |    1 +
 tests/output.at |    4 ++++
 3 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index fc20bf9..8073454 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2009-10-04  Joel E. Denny  <address@hidden>
+
+       tests: skip tests of file names that platform does not support.
+       Reported by Michael Raskin at
+       <http://lists.gnu.org/archive/html/bug-bison/2009-09/msg00001.html>.
+       * THANKS (Michael Raskin): Add.
+       * tests/output.at (AT_CHECK_OUTPUT_FILE_NAME): Fix.  Cygwin used
+       to fail at least for file names containing ":" or "\".
+
 2009-09-16  Akim Demaille  <address@hidden>
 
        doc: spell checking.
diff --git a/THANKS b/THANKS
index b48bb73..2b6751f 100644
--- a/THANKS
+++ b/THANKS
@@ -58,6 +58,7 @@ Martin Nylin              address@hidden
 Matt Kraai                address@hidden
 Matt Rosing               address@hidden
 Michael Hayes             address@hidden
+Michael Raskin            address@hidden
 Mickael Labau             address@hidden
 Mike Castle               address@hidden
 Neil Booth                address@hidden
diff --git a/tests/output.at b/tests/output.at
index c4b9640..e8f863d 100644
--- a/tests/output.at
+++ b/tests/output.at
@@ -167,6 +167,10 @@ AT_CHECK_CONFLICTING_OUTPUT([foo.y], [], [-o foo.y],
 m4_define([AT_CHECK_OUTPUT_FILE_NAME],
 [AT_SETUP([Output file name: $1])
 
+# Skip if platform doesn't support file name.  For example, Cygwin
+# doesn't support file names containing ":" or "\".
+AT_CHECK([[touch "]AS_ESCAPE([$1[.tmp]])[" || exit 77]])
+
 AT_DATA_GRAMMAR([glr.y],
 [[%glr-parser
 %code {
-- 
1.5.4.3