Re: Bug in #include guards

[Akim Demaille]

>>>>> "Alexander" == Alexander Belopolsky <address@hidden> writes:

Alexander> Akim Demaille writes:
>>  I'm applying this, thanks.
Alexander> <snip>
>> + for (cp = macro_name; *cp; ++cp) + if (islower (*cp)) + *cp =
>> toupper (*cp);
Alexander> <snip> In addition to my previous comment, I believe that
Alexander> upcasing all macro_name character is not a good idea for
Alexander> the same reason: include guards should be different in
Alexander> different file names.

If you have several pathnames mapping to the same UPPER_CASE_GUARD,
you are asking for problems by yourself.  Then, just don't depend on
these guard, and use a header yourself too.  After all, proper use of
Bison makes this feature absolutely useless.  That was done to please
users, not to solve an actual problem.