[Bug binutils/27158] New: RISC-V port still has UJ instruction type references

[wilson at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27158

            Bug ID: 27158
           Summary: RISC-V port still has UJ instruction type references
           Product: binutils
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: binutils
          Assignee: unassigned at sourceware dot org
          Reporter: wilson at gcc dot gnu.org
  Target Milestone: ---

RISC-V ISA v2.1 has a UJ instruction format that got renamed to J in ISA v2.2. 
But the source code still has references to the obsolete UJ instruction format.

rohan:2349$ grep UJ include/opcode/riscv.h
#define EXTRACT_UJTYPE_IMM(x) \
#define ENCODE_UJTYPE_IMM(x) \
#define VALID_UJTYPE_IMM(x) (EXTRACT_UJTYPE_IMM(ENCODE_UJTYPE_IMM(x)) == (x))
#define RISCV_UJTYPE(insn, rd, target) \
  ((MATCH_ ## insn) | ((rd) << OP_SH_RD) | ENCODE_UJTYPE_IMM(target))
rohan:2350$ 

These should be renmaed from UJTYPE to JTYPE.

This is just a minor quality of implementation issue and does not need to be
fixed before the release branch is made in a few days.

We still support .insh uj, ... but we can't change that without the risk of
breaking old user code that references the old instruction format name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.