[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug gas/26699] Failure to assemble aarch64 "isb sy" in LP64 Big Endian

From: cvs-commit at gcc dot gnu.org
Subject: [Bug gas/26699] Failure to assemble aarch64 "isb sy" in LP64 Big Endian host environment
Date: Tue, 06 Oct 2020 15:37:04 +0000


--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The binutils-2_35-branch branch has been updated by Alex Coplan


commit def9db5cb2a3e87ceada962a3269367b08dc4846
Author: Alex Coplan <alex.coplan@arm.com>
Date:   Tue Oct 6 15:56:44 2020 +0100

    aarch64: Fix bogus type punning in parse_barrier() [PR26699]

    This patch fixes a bogus use of type punning in parse_barrier() which
    was causing an assembly failure on big endian LP64 hosts when attempting
    to assemble "isb sy" for AArch64.

    The type of the entries in aarch64_barrier_opt_hsh is
    aarch64_name_value_pair. We were incorrectly casting this to the
    locally-defined asm_barrier_opt which has a wider type (on LP64) for the
    second member. This happened to work on little-endian hosts but fails on
    LP64 big endian.

    The fix is to use the correct type in parse_barrier(). This makes the
    locally-defined asm_barrier_opt redundant, so remove it.


            PR 26699
            * config/tc-aarch64.c (asm_barrier_opt): Delete.
            (parse_barrier): Fix bogus type punning.
            * testsuite/gas/aarch64/system.d: Update disassembly.
            * testsuite/gas/aarch64/system.s: Add isb sy test.

    (cherry picked from commit 05cfb0d8cc9b7f8676f5ae55a93642f091d5405f)

You are receiving this mail because:
You are on the CC list for the bug.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]