[Bug binutils/26082] New: infinite loop in windmc

[joelanderson333 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26082

            Bug ID: 26082
           Summary: infinite loop in windmc
           Product: binutils
           Version: 2.35 (HEAD)
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: binutils
          Assignee: unassigned at sourceware dot org
          Reporter: joelanderson333 at gmail dot com
  Target Milestone: ---

Created attachment 12590
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12590&action=edit
message missing end of message line

If a message text file ends before the end of message line (a period on a line
by itself), windmc will enter an infinite loop and consuming all available
memory until it is killed. This can be caused by either simply leaving out the
end of message line, or if it is followed by an EOF instead of a newline. I
have attached two sample files that cause the issue, one for each case.

I have attached a patch with the most direct solution - checking for the end of
input before attempting to read the next line. This causes windmc to exit with
the error message 'missing end of message text' instead of looping. While this
does not perfectly match the error message of mc.exe, which reports either an
invalid character or expected keyword, this seems like a more helpful error
message anyway. I'm happy to apply a different fix if there is a better way to
go about it, just let me know.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.