Memory leak in dwarf2.c

[Torsten Rupp]

Dear developers,

I detected (with the help of valgrind) a memory leak in dwarf2.c of
binutils 2.32:

In function_bfd_dwarf2_slurp_debug_info(), line 4367 the following call
is made for the scoped variable debug_filename:

      debug_filename = bfd_follow_build_id_debuglink (abfd, DEBUGDIR);

The returned value is allocated, but this memory is not freed in that
scope in all cases. I can fix the leak if I add at the end of the scope
after the lines (4393):

      symbols = bfd_get_outsymbols (debug_bfd);
      stash->syms = symbols;
      stash->close_on_cleanup = TRUE;

a call to:

      free (debug_filename);

Hopefully you will be able to add this fix in the next release of binutils.

Sincerly,

Torsten Rupp