Re: Translatable strings not marked 'c-format'

[Ask Hjorth Larsen]

This is the number of errors I find:

Summary
=======
da.po: 0 warnings / 1480 messages
es.po: 1 warnings / 1461 messages
fi.po: 1 warnings / 1478 messages
fr.po: 2 warnings / 1347 messages
id.po: 0 warnings / 880 messages
ja.po: 2 warnings / 1017 messages
ro.po: 0 warnings / 605 messages
ru.po: 2 warnings / 1347 messages
rw.po: 0 warnings / 2 messages
sr.po: 0 warnings / 1457 messages
sv.po: 0 warnings / 1400 messages
tr.po: 0 warnings / 646 messages
uk.po: 5 warnings / 1314 messages
vi.po: 3 warnings / 1342 messages
zh_CN.po: 0 warnings / 215 messages

However I don't know if the test logic is sufficient to detect all errors.

http://dcwww.camd.dtu.dk/~askhl/files/warnings.txt
http://dcwww.camd.dtu.dk/~askhl/files/bfd-stringcheck.py (requires pyg3t)

Best regards
Ask


2016-10-20 16:34 GMT+02:00 Ask Hjorth Larsen <address@hidden>:
> Hi Nick
>
> I just tested a message like this:
>
> #: coff-sh.c:2780 cofflink.c:2964
> #, c-format
> msgid "%B: illegal symbol index %ld in relocs"
> msgstr "%A: advarsel: illegalt symbolindeks %ld i relokeringerne"
>
> Note how the translation contains an erroneous %A instead of the correct %B.
>
> This is accepted by msgfmt.  Thus, the c-format flag cannot validate
> these codes.  It also accepts the message if %A or %B is omitted.
>
> The reason why msgfmt does not recognize them is that the %A/%B codes
> are defined by the error handler (bfd.c around line 600).   Meanwhile,
> msgfmt is only aware of the codes of printf.
>
> I see "/* Invoking %A with a null section pointer is an internal
> error.  */", followed by abort(), which means that superficially valid
> translation files can very easily result in abort() or possibly buffer
> overruns.
>
> My recommendation is to use the same string codes as printf.  Then
> faulty translations will be rejected by translationproject.
>
> I wrote a script to verify existing translations on the web page, and
> those that I tested had at least a few errors each.
>
> Best regards
> Ask
>
>
> 2016-10-20 12:47 GMT+02:00 Nick Clifton <address@hidden>:
>> Hi Ask,
>>
>>> Do you know when the translation
>>> templates on translationproject.org will be updated?
>>
>> On translationproject.org - no.  But I have just updated the
>> bfd.pot template in the binutils source repository (which I
>> forgot to do yesterday, sorry).
>>
>> Cheers
>>   Nick
>>