[Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols

[bugdal at aerifal dot cx]

https://sourceware.org/bugzilla/show_bug.cgi?id=18561

--- Comment #7 from Rich Felker <bugdal at aerifal dot cx> ---
I like it, but I think some effort should be put into understanding why the
wrong code was there to begin with and what the intent was. Here is the commit
that broke it:

https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=ae6063d440ba5ec28af81e9fc899cc099561339e;hp=f0abc2a11f47c3ecdfe0b54421092d17c70fc5f2

And like all awful GNU changelog messages, there is no explanation whatsoever
of the motivation/purpose for the changes, only redundant statements of change
content that could be reproduced by the version control logs.

To me, the logic in generic_force_reloc looks wrong: non-null fix->fx_subsy is
not a valid condition for doing a fixup instead of a relocation. But the
problem may be deeper.

It looks like many targets are affected, not just sh.

-- 
You are receiving this mail because:
You are on the CC list for the bug.