bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug binutils/18759] R_OR1K_*_PCREL should have pcrel_offset=TRUE


From: amodra at gmail dot com
Subject: [Bug binutils/18759] R_OR1K_*_PCREL should have pcrel_offset=TRUE
Date: Fri, 14 Aug 2015 02:27:25 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=18759

--- Comment #8 from Alan Modra <amodra at gmail dot com> ---
The test being disabled for or32 is not relevant.  The test can fail for all
sorts of reasons, most commonly that string merge is not supported by a target.
 What is relevant is that the test exercises R_OR1K_32_PCREL relocations, and
produces an incorrect binary after your patch.  Clearly, your patch is
responsible so I have reverted it.

Note that changing pcrel_offset is an ABI change.  It is quite possible to
define pcrelative relocations such that pcrel_offset should be false (but this
would be unusual for ELF).  So without looking at the ABI I can't say whether
your patch is wrong or just lacks a gas change.

-- 
You are receiving this mail because:
You are on the CC list for the bug.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]