bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug binutils/6913] New: [PATCH] binutils printf format string errors on


From: anders at kaseorg dot com
Subject: [Bug binutils/6913] New: [PATCH] binutils printf format string errors on Intrepid
Date: 24 Sep 2008 01:16:28 -0000

binutils HEAD and 2.18.50.0.9 fail to compile on Intrepid (which enables
-Wformat-security by default) because of these printf format string errors:

dwarf.c:189: error: format not a string literal and no format arguments
listing.c:1103: error: format not a string literal and no format arguments

diff -u -r1.38 dwarf.c
--- binutils/dwarf.c    1 Aug 2008 14:21:29 -0000       1.38
+++ binutils/dwarf.c    24 Sep 2008 01:11:37 -0000
@@ -186,7 +186,7 @@
   snprintf (buff, sizeof (buff), "%16.16lx ", val);
 #endif
 
-  printf (buff + (byte_size == 4 ? 8 : 0));
+  printf ("%s", buff + (byte_size == 4 ? 8 : 0));
 }
 
 static unsigned long int
diff -u -r1.34 listing.c
--- gas/listing.c       11 Apr 2008 09:06:02 -0000      1.34
+++ gas/listing.c       24 Sep 2008 01:11:37 -0000
@@ -1100,7 +1100,7 @@
   int pos = strlen (field_name);
   char **p;
 
-  fprintf (list_file, field_name);
+  fprintf (list_file, "%s", field_name);
   for (p = &argv[1]; *p != NULL; p++)
     if (**p == '-')
       {

-- 
           Summary: [PATCH] binutils printf format string errors on Intrepid
           Product: binutils
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: binutils
        AssignedTo: unassigned at sources dot redhat dot com
        ReportedBy: anders at kaseorg dot com
                CC: bug-binutils at gnu dot org


http://sourceware.org/bugzilla/show_bug.cgi?id=6913

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]