bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#20314: [PATCH] Make output of mdate-sh deterministic


From: Eric Dorland
Subject: bug#20314: [PATCH] Make output of mdate-sh deterministic
Date: Sat, 16 Sep 2017 21:57:28 -0400
User-agent: NeoMutt/20170113 (1.7.2)

This is a good change but it's not enough unfortunately to make it
reproducible.  mdate-sh also needs to support SOURCE_DATE_EPOCH. I'm
working on a patch for that.

* Mathieu Lirzin (address@hidden) wrote:
> Hello,
> 
> Reiner Herrmann <address@hidden> writes:
> 
> > mdate-sh pretty-prints the modification time of a file.
> > But it's output can vary depending on the timezone of
> > the caller. Someone in timezone GMT-12 will get a different
> > result (day) than someone in timezone GMT+12.
> >
> > As this output is also used to create/update stamp files,
> > which influence the further build process, the build result
> > can vary.
> > To enable reproducible builds and to have a more deterministic
> > build behavior, this change fixes the timezone to UTC.
> >
> > Signed-off-by: Reiner Herrmann <address@hidden>
> > ---
> >  lib/mdate-sh | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> 
> Applied with slight modifications in commit
> 7c25c996d1c7c212a5981aa0e9c4434b6f33f7b8
> 
> Thanks.
> 

-- 
Eric Dorland <address@hidden>
43CF 1228 F726 FD5B 474C  E962 C256 FBD5 0022 1E93

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]