bug#11791: recheck and compilation error

[Stefano Lattarini]

tags 11791 + patch
thanks

Hi Peter.

On 06/26/2012 01:56 PM, Peter Johansson wrote:
> Hello automakers,
> 
> I've noticed the following behavior from 'make recheck'.
> 
> If I run 'make check' and one test fails
>
>   $ make check
>   ...
>   FAIL: foo.test
> 
> I modify the test
>
>   $ edit foo.c
>
> and rerun the test suite with
>
>   $ make recheck -k
>   foo.c:1: error: parse error before '}' token
>   make[1]: *** [foo.o] Error 1
>   make[1]: Target `test-suite.log' not remade because of errors.
>   make: *** [recheck] Error 2
> 
> which is now interrupted as I introduced a compilation error.
> If I now try edit the test again and rerun test suite with
>
>   $ make recheck -k
>
> I get
>
>   # TOTAL: 0
>   # PASS:  0
>   # SKIP:  0
>   # XFAIL: 0
>   # FAIL:  0
>   # XPASS: 0
>   # ERROR: 0
> 
> that is, the failed test is not rerun.  I suppose the reason is that it
> was never run last time and that there exist no trs file, but this is
> IMHO suboptimal and unexpected.
> I would expect that make recheck also includes tests that failed due
> to compilation problems or at least tests that failed last time they
> were run.
>
I agree.  The attached patch should solve the issue.   It's more ugly
than I'd like, but this bug is annoying enough to make such ugliness
acceptable.  I will push (to maint) in a couple of days if there are
no objections.

> Please find a script attached illustrating the behavior.
> 
> This is with automake 1.12.
> 
> Cheers,
> Peter
> 

Thanks,
  Stefano

0001-parallel-tests-recheck-behaves-better-in-case-of-com.patch
Description: Text Data