Re: Remove dependency on gunzip

[Ralf Wildenhues]

Hello Antonio,

sorry for the delay.

* Antonio Diaz Diaz wrote on Fri, Oct 30, 2009 at 09:09:47PM CET:
> Ralf Wildenhues wrote:
> >>As gunzip is a link to gzip, the only difference between using
> >>"gunzip" and "gzip -d" is that the former adds a gratuitous
> >>dependency on the gunzip name.
> >
> >Well, from the user's perspective, who never needs 'make dist', your
> >patch adds a gratuitous dependency on the gzip name, no?
> 
> distcheck depends on dist, so no, my patch does not add any
> dependency for anybody.

Well, distcheck is a target for the maintainer/developer though, not
usually for the end-user.  But your point is taken anyway, for
compression programs where the compressor is equally likely to be
present on a system (typically, for all the free ones).

> Using the same name (gzip) for compressing
> and decompressing the tarball only reduces the total number of
> dependencies.

Yes, that is true.

> >Don't get me wrong.  If there is a distinct advantage to doing this
> >move, then we should probably do it, but it's a NEWS-worthy change, and
> >it should be done for all compressors for which the same reasoning
> >holds.
> 
> I agree it should be done for all the gzip-like compressors. In fact
> it is already done for xz:

Yep.  I'm applying this to remove the dependency upon unlzma, gunzip,
and bunzip2, and adding you to THANKS, to the maint branch, intended
for master and branch-1.11.

Cheers,
Ralf

2009-12-05  Antonio Diaz Diaz  <address@hidden>

        Replace unlzma, gunzip, bunzip2 with pack tool -d invocation.
        * lib/am/distdir.am (distcheck): Use lzma -d, gzip -d, bzip2 -d,
        instead of the respective un$tool invocation, to avoid depending
        on another tool.
        * THANKS: Update.

diff --git a/lib/am/distdir.am b/lib/am/distdir.am
index dcaed5e..ec4d5e5 100644
--- a/lib/am/distdir.am
+++ b/lib/am/distdir.am
@@ -424,17 +424,17 @@ endif %?SUBDIRS%
 distcheck: dist
        case '$(DIST_ARCHIVES)' in \
        *.tar.gz*) \
-         GZIP=$(GZIP_ENV) gunzip -c $(distdir).tar.gz | $(am__untar) ;;\
+         GZIP=$(GZIP_ENV) gzip -dc $(distdir).tar.gz | $(am__untar) ;;\
        *.tar.bz2*) \
-         bunzip2 -c $(distdir).tar.bz2 | $(am__untar) ;;\
+         bzip2 -dc $(distdir).tar.bz2 | $(am__untar) ;;\
        *.tar.lzma*) \
-         unlzma -c $(distdir).tar.lzma | $(am__untar) ;;\
+         lzma -dc $(distdir).tar.lzma | $(am__untar) ;;\
        *.tar.xz*) \
          xz -dc $(distdir).tar.xz | $(am__untar) ;;\
        *.tar.Z*) \
          uncompress -c $(distdir).tar.Z | $(am__untar) ;;\
        *.shar.gz*) \
-         GZIP=$(GZIP_ENV) gunzip -c $(distdir).shar.gz | unshar ;;\
+         GZIP=$(GZIP_ENV) gzip -dc $(distdir).shar.gz | unshar ;;\
        *.zip*) \
          unzip $(distdir).zip ;;\
        esac