bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: some automake-1.10 tests fail because of lacking go=x permissions


From: Ralf Wildenhues
Subject: Re: some automake-1.10 tests fail because of lacking go=x permissions
Date: Tue, 8 Jan 2008 21:47:46 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

Hello Arto,

* address@hidden wrote on Tue, May 08, 2007 at 05:46:27PM CEST:
> 
> When unpacking the automake-1.10 tarball by a different user
> (e.g. root, with 'tar xpf -' ) and then building and running
> 'make check' from a different object directory, some tests
> fail because of missing execute permissions:
> 
> /bin/ksh[9]: /build/automake-1.10/tests/cond33.test: cannot execute
> 
> This is because some *.test files have permission rwxr--r--
> instead of rwxr-xr-x.
[...]

Thanks for the bug report, and apologies for the long delay.
I am applying this to master and branch-1-10 (and putting you
in THANKS), so that we don't have to remember doing the change
by hand.

Cheers,
Ralf

2008-01-08  Ralf Wildenhues  <address@hidden>

        * Makefile.am (dist-hook): New, ensure world-executable tests.
        * THANKS: Update.
        Report by Arto C. Nirkko.

diff --git a/Makefile.am b/Makefile.am
index bb069df..6a370cf 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -3,7 +3,7 @@
 ## Makefile for Automake.
 
 ## Copyright (C) 1995, 1996, 1997, 1998, 1999, 2001, 2002, 2003, 2004,
-## 2005, 2006, 2007  Free Software Foundation, Inc.
+## 2005, 2006, 2007, 2008  Free Software Foundation, Inc.
 
 ## This program is free software; you can redistribute it and/or modify
 ## it under the terms of the GNU General Public License as published by
@@ -101,6 +101,10 @@ INSTALL: lib/INSTALL
 ## to anybody else
 ##
 
+# Ensure tests are world-executable
+dist-hook:
+       cd $(distdir)/tests && chmod a+rx *.test
+
 # Some simple checks, and then ordinary check.  These are only really
 # guaranteed to work on my machine.
 maintainer-check: automake aclocal




reply via email to

[Prev in Thread] Current Thread [Next in Thread]