bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug in m4/gcj.m4 (CVS head)


From: Alexandre Duret-Lutz
Subject: Re: bug in m4/gcj.m4 (CVS head)
Date: 23 Oct 2001 14:26:15 +0200
User-agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7

>>> "Olivier" == Olivier  <address@hidden> writes:

[...]

 Olivier> if test "x${GCJFLAGS+set}" = xset; then
 Olivier> GCJFLAGS="-g -O2"
 Olivier> fi

 Olivier> shouldn't that be something like:

 Olivier> if test "x$GCJFLAGS" = x; then
 Olivier> ...

Not really, because you don't want to override GCJFLAGS if it's
defined but empty, as in:

  GCJFLAGS= ./configure


2001-10-23  Alexandre Duret-Lutz  <address@hidden>

        * m4/gcj.m4 (AM_PROG_GCJ): Define GCJFLAGS if unset.
        Reported by Olivier Louchart-Fletcher <address@hidden>.

Index: m4/gcj.m4
===================================================================
RCS file: /cvs/automake/automake/m4/gcj.m4,v
retrieving revision 1.5
diff -u -r1.5 gcj.m4
--- gcj.m4      2001/09/22 16:05:36     1.5
+++ gcj.m4      2001/10/23 12:11:26
@@ -21,7 +21,7 @@
 AC_DEFUN([AM_PROG_GCJ],[
 AC_CHECK_PROGS(GCJ, gcj, gcj)
 test -z "$GCJ" && AC_MSG_ERROR([no acceptable gcj found in \$PATH])
-if test "x${GCJFLAGS+set}" = xset; then
+if test "x${GCJFLAGS-unset}" = xunset; then
    GCJFLAGS="-g -O2"
 fi
 AC_SUBST(GCJFLAGS)
Index: THANKS
===================================================================
RCS file: /cvs/automake/automake/THANKS,v
retrieving revision 1.150
diff -u -r1.150 THANKS
--- THANKS      2001/10/17 17:20:49     1.150
+++ THANKS      2001/10/23 12:11:26
@@ -115,6 +115,7 @@
 Noah Friedman          address@hidden
 Nyul Laszlo            address@hidden
 OKUJI Yoshinori                address@hidden
+Olivier Louchart-Fletcher address@hidden
 Olly Betts             address@hidden
 Paul Berrevoets                address@hidden
 Paul D. Smith          address@hidden
-- 
Alexandre Duret-Lutz



reply via email to

[Prev in Thread] Current Thread [Next in Thread]