bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bug in list of files displayed on 'automake --help'


From: Gary V . Vaughan
Subject: Re: [PATCH] bug in list of files displayed on 'automake --help'
Date: Tue, 17 Jul 2001 20:47:28 +0100

On Tuesday 17 July 2001  6:50 am, Tom Tromey wrote:
> >>>>> "Gary" == Gary V Vaughan <address@hidden> writes:
>
> Gary> That seems like a terribly complicated way to achieve it.  My
> Gary> patch on branch-1-4 seems cleaner...
>
> I don't think we want patches in 1.4 that aren't also evaluated for
> 1.5.
>
> Did you send this patch to automake-patches?  You might not be aware
> of that requirement?  (Sometimes I'm not :-)

Mea culpe.  In my enthusiasm to ship p5 on Sunday while I had a few hours to 
spare, I made what I thought was an obvious fix, and neglected to inform the 
patches list :-(

> If I understand correctly, your patch adds the `+ 1' here:
>
>         $two = $lcomm[$max + $i + 1];
>         $three = $lcomm[2 * $max + $i + 1];
>         $four = $lcomm[3 * $max + $i + 1];

Yup.

> I think this happens to work because the modulus is 1 right now.  Does
> it work even if you add or remove an element from @common_files?
>
> If the modulus were 2 then I think you'd have to remove the `+ 1' from
> the $two line.
>
> Do you agree?

Yes, I see what you mean.  You would think I'd have learned not to pretend 
that I can code in perl by now... 

I could backport the trunk patch incase we do need a p6 between now and 1.5 
if you'd like?

Cheers,
        Gary.
-- 
  ())_. Gary V. Vaughan     gary@(oranda.demon.co.uk|gnu.org)
  ( '/  Research Scientist  http://www.oranda.demon.co.uk       ,_())____
  / )=  GNU Hacker          http://www.gnu.org/software/libtool  \'      `&
`(_~)_  Tech' Author        http://sources.redhat.com/autobook   =`---d__/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]