bug#21873: closed (Re: bug#21873: Issue on emacs --daemon with View command)

[Mosè Giordano]

Hi Santiago,

2015-11-12 10:00 GMT+01:00 Santiago Saavedra <address@hidden>:
>> thanks for the patch, I applied it with minor changes (XEmacs doesn't
>> have `display-graphic-p', I kept the old test).
>
> Alright, but there is a problem with the current test. Because getenv
> searches in process-environment by default, if Emacs is run with
> --daemon from outside the user's X scope, it will stay false (as
> intended), but if it is run from an X screen, and then an emacsclient
> is spawned via, e.g., an ssh (-x) connection it will show up evince on
> the server. So getenv should receive the current frame as an extra
> parameter.
>
> That may just be corrected by (getenv "DISPLAY" (selected-frame)).
>
> Thanks for including the patch anyway.
>
> I've uploaded my repo to contain such additional patch.
>
> Here it is: 
> https://github.com/ssaavedra/auctex/commit/c725ac694334f9c9b5694ff17a8945223e128972.patch

Thanks again, but before Emacs 23 `getenv' didn't have the FRAME
argument anyway, so now I use the current check for old Emacsen (no
one complained about that so far, so I don't think it would be a
problem to keep it), and `display-graphic-p' for newer versions.

>> Luckily it was a minor change and mainly a reorganization of existing
>> code, but should you want to send further patches you would need to
>> assign the copyright to FSF in order for them to be installed in
>> AUCTeX ;-)
>
> I have no problem assigning the copyright of AUCTeX contributions to
> FSF, so please tell me in this regard what would I need to do. But any
> of these patches are small enough, I think.

If you're willing to release your code under the terms of the GPL and
assign the copyright to FSF, please follow the instructions at
http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future
 For the package to indicate, you can choose either AUCTeX or Emacs,
both covers contributions to AUCTeX, but only Emacs covers
contributions for all packages included in it (like RefTeX), and
packages distributed via GNU ELPA, in addition to Emacs itself, of
course.  For these reasons, we suggest to indicate Emacs rather than
AUCTeX.  Of course, you may also assign the copyright for any other
GNU package you may be interested in.

Bye,
Mosè