[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Is svn release 1758 missing fixes?

From: Dr . Jürgen Sauermann
Subject: Re: Is svn release 1758 missing fixes?
Date: Mon, 4 Mar 2024 15:44:29 +0100
User-agent: Mozilla Thunderbird

Hi Mike,

sorry for that, it came after #ifdef APPLE so I did not notice it.
I am not a MAC owner, so I can't compile myself but rather depend
on your reports.

Now hopefully fixed in SVN 1760.

As to svn, you simply check out GNU APL once (as you did) and then

svn up

to fetch that changes that I made.

Best Regards,

On 3/3/24 22:08, M.Hall wrote:
Is svn release 1758 missing fixes for Backtrace.cc and Command.cc ?
On macos 10.15.7 (old, I know).
I added small fixes in my "working copy" below to avoid compile errors - the diff will show them.
(Also, '__APPLE__' is defined by the compiler.  See the output of 'echo | g++ -dM -E -' as in the libapl bug report.)

$ svn up

$ svn info
Path: .
Working Copy Root Path: /Volumes/Archive/Language/APL/gnu-apl/SVN/trunk
URL: http://svn.savannah.gnu.org/svn/apl/trunk
Relative URL: ^/trunk
Repository Root: http://svn.savannah.gnu.org/svn/apl
Repository UUID: bd74f7bd-1a55-4bac-9fab-68015b139e80
Revision: 1758
Node Kind: directory
Schedule: normal
Last Changed Author: j_sauermann
Last Changed Rev: 1758
Last Changed Date: 2024-03-03 08:22:02 -0600 (Sun, 03 Mar 2024)

$ svn diff

Index: src/Backtrace.cc
--- src/Backtrace.cc (revision 1758)
+++ src/Backtrace.cc (working copy)
@@ -364,7 +364,7 @@
               *e = '\0';
               fun = e + 1;
               abs_addr = strtoll(a_a, nullptr, 16);
-              abs_addr -= main_offset 0;
+              abs_addr -= main_offset_0;
Index: src/Command.cc
--- src/Command.cc (revision 1758)
+++ src/Command.cc (working copy)
@@ -2024,6 +2024,9 @@
    if (access(name.c_str(), R_OK) == 0)   // file is readable
         struct stat st;
+#ifdef __APPLE__
+#define st_mtim  st_mtimespec
         if (stat(name.c_str(), &st) == 0)   // got stat
              if (sort == SORT_SIZE)   return st.st_size;

Or is there a 'subversion' way to pull in these fixes?
Backtrace.cc was fixed in 1752.
Command.cc was fixed in 1753.
But when I do a full 'checkout' or an 'upgrade' they do not appear.
I'm a total beginner to svn, so I could be using it the wrong way.

Thank you!
Mike Hall

reply via email to

[Prev in Thread] Current Thread [Next in Thread]