[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Is svn release 1758 missing fixes?

From: Dr . Jürgen Sauermann
Subject: Re: Is svn release 1758 missing fixes?
Date: Mon, 4 Mar 2024 15:19:57 +0100
User-agent: Mozilla Thunderbird

Hi Paul,

thanks, fixed in SVN 1759 as proposed. I was initially thinking of

return st.st_mtime;

myself but didn't do it because is is a macro and I wasn't sure if it is #define'd
on all platform.

Best Regards,

On 3/4/24 02:49, Paul Rockwell wrote:

I noticed the same issues in SVN 1757 and 1758 as well. I have made similar fixes in the source that I have.

Our fixes differ in that the fix I made to Command.cc is to change line 2030 from 
if (sort == SORT_TIME) return st.st_mtim.tv_sec;
if (sort == SORT_TIME) return st.st_mtime;

Both Linux and macOS #define st_mtime to be st.st_mtim.tv_sec (Linux) or st.st_mtimespec.tv_sec (macOS) to provide backward compatibility. That way we don't need the 
test for __APPLE__.

- Paul Rockwell

reply via email to

[Prev in Thread] Current Thread [Next in Thread]