[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-apl] Miscellaneous minor fixes

From: Alexey Dokuchaev
Subject: [Bug-apl] Miscellaneous minor fixes
Date: Thu, 4 Jul 2019 21:13:22 +0800

Building APL with GCC 7/8 required some minor patching: src/Error.hh,
in set_error_line_X() methods, there are calls to strncpy(3), so it
needs #include <cstring> or #include <string.h>.

Also, had to change types of total_memory from unsigned to signed,
those values are compared to values of type rlim_t which is signed.
Such comparison causes error.  Since there types are 64-bit, it does
not make sense to make them unsigned, they are huge enough to hold any
reasonable values, be it positive or negative.

On FreeBSD, I've also needed to explicitly #include <sys/socket.h>
which on GNU/Linux is included implicitly via other headers.  And two
calls to ::bind() were missing global namespace specifier which broke
the builds with compilers that default to newish C++ standards.


Attachment: misc-fixes.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]