[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-apl] Support for help command in emacs-mode

From: Alexey Veretennikov
Subject: Re: [Bug-apl] Support for help command in emacs-mode
Date: Wed, 10 Jan 2018 10:31:00 +0100

Hi Elias,

Could you please do you do what Juergen has requested so we can get the changes in?


2018-01-07 17:51 GMT+01:00 Juergen Sauermann <address@hidden>:

yes, but it is Elias who can OK the files. The proper order should be:

1. sync GNU APL sources to Elias' git
2. apply changes and test Emacs
3. sync Elias' git to my local GNU APL repo
4. commit to public GNU APL repo

If I would apply the changes directly to the GNU APL repo then the
GNU APL repo and Elias' git would remain out of sync, which is
generally undesirable.

/// Jürgen

On 01/07/2018 05:29 PM, Alexey Veretennikov wrote:

The files I've attached are based on the sources from SVN, not git.


On Jan 7, 2018 4:52 PM, "Juergen Sauermann" <address@hidden <mailto:address@hiddenline.de>> wrote:


    they are actually used (I sync my sources from your git repo). I
    suppose that you applied
    Alexey's patch to your sources and the result doesn't compile when
    I fetch the changes from
    your git repo.

    I would prefer if the two repos remain in sync as long as they
    both exist.

    If you would simply remove your emacs repo then I would become
    for the emacs sources in GNU APL which is close to impossible
    because I have no
    idea how emacs works.

    Best Regards,
    /// Jürgen

    On 01/07/2018 04:19 PM, Elias Mårtenson wrote:
    That's OK. The C++ sources in my repository isn't actually used.
    I should probably remove them from the gnu-apl-mode repository.

    The code in the main GNU APL repository is the official source.


    On 7 January 2018 at 22:53, Juergen Sauermann
    <mailto:address@hiddenline.de>> wrote:


        it seems like Elias' sources in git are slightly out of sync
        with the current GNU APL sources.
        For example (emacs.hh around line 55):

        *- return string((const char *)&utf[0], utf.size());**
        **+    return string((const char *)(utf.get_items()),
        Best Regards,
        /// Jürgen

        On 01/07/2018 02:12 PM, Elias Mårtenson wrote:
        Thank you for this work. This is something have planned to
        do for a while but never got around to.

        I merged your changes and tested, and it all seems to work
        fine. I'll merge this into gnu-apl-mode, but Jürgen needs to
        do the same on his side before this is complete.


        On 7 January 2018 at 18:48, Alexey Veretennikov
        <mailto:address@hiddenail.com>> wrote:

            Hi Juergen, Elias and all,

            Some time ago we have been discussing the idea to move
            help from
            gnu-apl-mode in Emacs into the GNU APL itself.

            Now since we have a help in GNU APL, I've implemented
            network command in
            emacs_mode part of GNU APL which will send requested
            help as a list of
            S-expressions ready to be parsed on a Emacs side. See
            patches and new
            files attached (to be applied/added into the
            src/emacs_mode directory)

            I've also implemented support for this command in
            corresponding pull-request is here:

            This combination has been tested locally.
            The changes are backwards-compatible.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]