[Bug-apl] Errors on SAVE/LOAD with SI not empty

[Kacper Gutowski]

Hi,

1. Trying to )SAVE (or )CONTINUE) while stopped on SYNTAX ERROR,
causes segmentation fault:

      +
SYNTAX ERROR
      +
      ^
      )SAVE FOO


====================================================
SEGMENTATION FAULT

----------------------------------------
-- Stack trace at main.cc:113
----------------------------------------
0x7f13d18a8995 __libc_start_main
0x434135  main
0x51cabd   Workspace::immediate_execution(bool)
0x46153d    Command::process_line()
0x46119f     Command::process_line(UCS_string&)
0x51f9c5      Workspace::save_WS(std::ostream&, std::vector<UCS_string, 
std::allocator<UCS_string> >&)
0x440378       XML_Saving_Archive::save()
0x43c30f        XML_Saving_Archive::operator<<(StateIndicator const&)
0x7f13d339f210         
0x476a7a          
========================================
====================================================



2. For every other error, it fails when trying to )LOAD workspace
that was saved with non-empty state indicator:

      ⎕ES'FOO'
FOO
      ⎕ES 'FOO'
      ^
      )SAVE FOO
2014-02-02  22:40:59 (GMT+1)
      )LOAD FOO

==============================================================================
Assertion failed: lev == level
in Function:      read_SI_entry
in file:          Archive.cc:1594

Call stack:

----------------------------------------
-- Stack trace at Archive.cc:1594
----------------------------------------
0x7fde0eb87995 __libc_start_main
0x434135  main
0x51cabd   Workspace::immediate_execution(bool)
0x46153d    Command::process_line()
0x460fcd     Command::process_line(UCS_string&)
0x51ed29      Workspace::load_WS(std::ostream&, std::vector<UCS_string, 
std::allocator<UCS_string> > const&)
0x44116c       XML_Loading_Archive::read_Workspace()
0x43f12d        XML_Loading_Archive::read_StateIndicator()
0x43f0b4         XML_Loading_Archive::read_SI_entry(int)
0x44294f          do_Assert(char const*, char const*, char const*, int)
========================================

SI stack:


==============================================================================
*** immediate_execution() caught other exception ***



On the side note, timestamp displayed on )SAVE and )LOAD is in UTC+0
(sometimes aka GMT) even though local timezone is printed alongside it.
And additionally, hours/minutes/second are printed without leading zeros
on )LOAD which can yield something like:
$ faketime '2015-01-01 02:01' apl --silent 
      )SAVE FOO
2015-01-01  01:01:02 (GMT+1)
      )LOAD FOO
SAVED 2015-1-1  1:1:2 (GMT+1)
      )OFF


-k