[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bongo-devel] Re: Bongo marking and selecting random tracks
From: |
Daniel Jensen |
Subject: |
[bongo-devel] Re: Bongo marking and selecting random tracks |
Date: |
Sat, 24 Mar 2007 15:57:56 +0100 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.95 (gnu/linux) |
Anthony Chaumas-Pellet <address@hidden> writes:
> The one problem at present is that the track currently playing can be
> picked when choosing a new track (at least when I explicitly ask for a
> new random track). A quick fix is to also check against
> (not (bongo-currently-playing-track-line-p)).
>
> This 'random choice picks same track' behaviour seems specific to
> 'random-marked', as it doesn't appear when no tracks are marked.
Well, I can reproduce the behaviour with unmarked tracks also. It is
because the currently playing track is not marked as "played" before
the new track is selected. Your fix is good. As an alternative, we
could make `bongo-play-random' stop before picking a random track. The
third option is to set the played property for the currently playing
track, but that is a potentially bigger change.