bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Dlang] Internationalisation WIP


From: Adela Vais
Subject: Re: [Dlang] Internationalisation WIP
Date: Wed, 6 Jan 2021 17:11:00 +0200

Hello,

I took another look in the C skeleton and only now I see that _ is not
handled there. It's the user's task to handle it.

Bisthromatic has this, for example:
  #if defined ENABLE_NLS && ENABLE_NLS
  # define _(Msgid)  gettext (Msgid)
  #else
  # define _(Msgid)  (Msgid)
  #endif

I am changing the skeleton to remove it.

Adela

În mar., 5 ian. 2021 la 20:57, Akim Demaille <akim@lrde.epita.fr> a scris:

>
>
> > Le 5 janv. 2021 à 17:19, Adela Vais <adela.vais99@gmail.com> a écrit :
> >
> > Hello!
> >
> > The following 4 commits regard the internationalisation, and the removal
> of: yytnamerr, $end, and some unused imports caused by the
> internationalisation (now the import of std.conv is at global scope, not
> only used by lookahead correction).
>
> Excellent work, thanks Adela!
>
> I squashed 2 and 3 together (2 was modifying yytnamerr, and 3 removed it).
>
> I was about to push this, but it does not run properly on my machine.
>
> 572. calc.at:1460: testing Calculator D parse.error=custom  ...
> /Users/akim/src/gnu/bison/tests/calc.at:1460: COLUMNS=1000; export
> COLUMNS; NO_TERM_HYPERLINKS=1; export NO_TERM_HYPERLINKS;  bison --color=no
> -fno-caret -Wno-deprecated -o calc.d calc.y
> /Users/akim/src/gnu/bison/tests/calc.at:1460: $DC $DCFLAGS   -ofcalc
> calc.d
> stderr:
> Undefined symbols for architecture x86_64:
>   "_gettext", referenced from:
>       __D4calc1_FAyaZQe in calc.o
> ld: symbol(s) not found for architecture x86_64
> clang: error: linker command failed with exit code 1 (use -v to see
> invocation)
> Error: linker exited with status 1
> stdout:
> /Users/akim/src/gnu/bison/tests/calc.at:1460: exit code was 1, expected 0
> 572. calc.at:1460: 572. Calculator D parse.error=custom  (calc.at:1460):
> FAILED (calc.at:1460)
>
> We need a way to make this portable.  I expect we'd also get a failure on
> the CI.
>
> Why is this failing on my machine?  What have you done for it to work for
> you?
>
> Unfortunately the patches don't commute, I can't install 2 and 3 without 1.

Attachment: 0001-d-add-internationalisation-support.patch
Description: Binary data

Attachment: 0002-d-remove-yytnamerr-usage.patch
Description: Binary data

Attachment: 0003-d-remove-unnecessary-imports.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]