[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
fixed (mistake ? in bbdb-com.el) Re: how to pass arguments to bbdb-creat
From: |
Gijs Hillenius |
Subject: |
fixed (mistake ? in bbdb-com.el) Re: how to pass arguments to bbdb-create-internal |
Date: |
Wed, 10 Jan 2018 12:01:56 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
On 10 Jan 2018, Gijs Hillenius wrote:
> On 10 Jan 2018, Bob Newell wrote:
>
>>
>> I ran into this also when converting gmail2bbdb.el, originally by
>> Chen Bin. I was able to get most everything working but had a lot of
>> trouble with phone numbers.
>>
>> Still, the new format with keywords is very much to be preferred.
>
> Thanks to Roland for confirming there were changes to
> bbdb-create-internal, and thanks also to Bob, who shared his code in
> an email, it was very easy to adapt bbdb-csv-import.el
>
> except, indeed, for the phone numbers. Using ":phone phone" gives an
> error: "Wrong type argument: arrayp, nil". I'll be looking into that
I think I found a mistake in bbdb-com.el
on line 984 it says 'phone record', whereas I suspect it should be
'record phone' like in the other sections of the bbdb-create-internal
function
(`:phone
(let ((phone (pop spec)))
(if check (bbdb-check-type phone (bbdb-record-phone record-type)
t))
--> (bbdb-record-set-phone phone record)))
When I replace this ^^ section by this:
(`:phone
(let ((phone (pop spec)))
(if check (bbdb-check-type phone (bbdb-record-phone record-type)
t))
---> (bbdb-record-set-phone record phone)))