[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Axiom-developer] Maintainers

From: Gabriel Dos Reis
Subject: Re: [Axiom-developer] Maintainers
Date: 04 Nov 2006 07:32:07 +0100

root <address@hidden> writes:

| > But, the check-in would have been approved after review, not before!
| Actually, both. 
| The check-in needs to be reviewed before it is committed back to the
| axiom--silver--1 branch to make sure it doesn't break other pending
| changes.
| The check-in needs to be reviewed after it is committed by the author
| to make sure their changes are all correctly applied and by the silver
| maintainer to make sure that nothing broke.

Only because you have introduced an unnecessary step.

Patch is reviewed, and accepted.  Author has the responsability to
check in as approved.  Period.

Now, if you introduce that walk-around, people have to check that you
did not mess up their changes.  This is compounded by the fact that we
know of this changes only after a day, when possibly other changes
have been applied too.  Remove the unnecessary step; make the source

-- Gaby

reply via email to

[Prev in Thread] Current Thread [Next in Thread]