[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [avr-libc-dev] [RFC,patch] xmodem-crc
From: |
E . Weddington |
Subject: |
Re: [avr-libc-dev] [RFC,patch] xmodem-crc |
Date: |
Mon, 10 Nov 2003 17:55:04 GMT |
> Hi,
>
> Attached is a patch for avr/crc.h which adds dox and the
xmodem crc
> function.
>
> Any objections to committing this to HEAD and 1.0?
>
> Ted Roth
>
1. This would add a new function (API) so shouldn't it only
go into HEAD according to policy?
2. Your "xmodem crc" polynomial of x^16+x^12+x^5+1 (for
easier notation: [16,12,5,1]) is also more commonly known
as the CRC-CCITT (Comité Consultatif International
Télégraphique et Téléphonique) and is used in many
different protocols, not just XMODEM. I would suggest
renaming the function to reflect that it is the CCITT CRC,
as most people (I would think), when they look for a CRC
function, would be looking for a "CCITT" CRC.
I'm getting some of this info from _Numerical Recipes in
C_, 2nd edition by Press, Teukolsky, Vetterling, and
Flannery.
Eric