Re: make dist: sources missing

[Ralf Wildenhues]

Hello Christian,

* Christian Rössel wrote on Fri, Apr 17, 2009 at 06:35:54PM CEST:
> in the following project "make" succeeds but in the result of "make
> dist" the source test/src/bar.c is missing. "make distcheck" fails.

> "make distcheck" fails with the message:
> ERROR: files left in build directory after distclean:
> ./src/bar.c

> bar.c is not in $(top_srcdir) nor in a subdirectory. Is that the
> problem? I haven't found anything in the docs. The docs state
> "all source files are automatically included in a distribution"

Yes.

> My Makefile.am and configure.ac are as follows:
> 
> Makefile.am:
> bin_PROGRAMS =
> bin_PROGRAMS += bar
> bar_SOURCES = $(top_srcdir)/../src/bar.c

Make that line
  bar_SOURCES = src/bar.c

or
  bar_SOURCES = bar.c

depending on where, relative to the location of the Makefile.am file,
the bar.c file is.

> bin_PROGRAMS += foo
> foo_SOURCES = $(top_srcdir)/src/foo.c

Likewise, make that line
  foo_SOURCES = src/foo.c

or
  foo_SOURCES = foo.c

You don't need the top_srcdir references here.  Also, the top_srcdir
variable references the top source directory, and going higher up than
that (with "$(top_srcdir)/..") can be asking for trouble.

Hope that helps.

Cheers,
Ralf