Re: libtool 2.1a failed mdemo-make.test on Solaris

[Bruno Haible]

Alexandre Duret-Lutz wrote:
>  Bruno> all-local $(libfoo_la_OBJECTS): $(ARGZ_H)
>
> Hmmm, why do you need this since $(ARGZ_H) is already in
> $(BUILT_SOURCES), and "all" depends on $(BUILT_SOURCES)?

You are right, the presence of $(ARGZ_H) in $(BUILT_SOURCES) makes this
rule unnecessary. (Historically, the rule predates the use of BUILT_SOURCES.)
Thanks for the hint. I propose this patch in gnulib.

Bruno


2005-07-22  Bruno Haible  <address@hidden>

        * modules/alloca-opt (Makefile.am): Remove explicit dependency on
        $(ALLOCA_H), redundant through BUILT_SOURCES.
        * modules/argz (Makefile.am): Remove explicit dependency on $(ARGZ_H),
        redundant through BUILT_SOURCES.
        * modules/byteswap (Makefile.am): Remove explicit dependency on
        $(BYTESWAP_H), redundant through BUILT_SOURCES.
        * modules/fnmatch (Makefile.am): Remove explicit dependency on
        $(FNMATCH_H), redundant through BUILT_SOURCES.
        * modules/getopt (Makefile.am): Remove explicit dependency on
        $(GETOPT_H), redundant through BUILT_SOURCES.
        * modules/glob (Makefile.am): Remove explicit dependency on $(GLOB_H),
        redundant through BUILT_SOURCES.
        * modules/poll (Makefile.am): Remove explicit dependency on $(POLL_H),
        redundant through BUILT_SOURCES.
        * modules/stdbool (Makefile.am): Remove explicit dependency on
        $(STDBOOL_H), redundant through BUILT_SOURCES.
        * modules/stdint (Makefile.am): Remove explicit dependency on
        $(STDINT_H), redundant through BUILT_SOURCES.
        * modules/sysexits (Makefile.am): Add $(SYSEXITS_H) to BUILT_SOURCES.
        Remove explicit dependency on $(SYSEXITS_H).
        Reported by Alexandre Duret-Lutz <address@hidden>.

*** modules/alloca-opt  29 Sep 2004 22:10:44 -0000      1.1
--- modules/alloca-opt  22 Jul 2005 19:30:39 -0000
***************
*** 18,24 ****
  
  # We need the following in order to create an <alloca.h> when the system
  # doesn't have one that works with the given compiler.
- all-local $(lib_OBJECTS): $(ALLOCA_H)
  alloca.h: alloca_.h
        cp $(srcdir)/alloca_.h address@hidden
        mv address@hidden $@
--- 18,23 ----
*** modules/argz        22 Sep 2004 16:23:27 -0000      1.3
--- modules/argz        22 Jul 2005 19:30:39 -0000
***************
*** 17,23 ****
  
  # We need the following in order to create an <argz.h> when the system
  # doesn't have one that works with the given compiler.
- all-local $(lib_OBJECTS): $(ARGZ_H)
  argz.h: argz_.h
        cp $(srcdir)/argz_.h address@hidden
        mv address@hidden $@
--- 17,22 ----
*** modules/byteswap    1 May 2005 14:13:02 -0000       1.1
--- modules/byteswap    22 Jul 2005 19:30:39 -0000
***************
*** 16,22 ****
  
  # We need the following in order to create a <byteswap.h> when the system
  # doesn't have one.
- all-local $(lib_OBJECTS): $(BYTESWAP_H)
  byteswap.h: byteswap_.h
        cp $(srcdir)/$< address@hidden
        mv address@hidden $@
--- 16,21 ----
*** modules/fnmatch     6 May 2005 17:22:45 -0000       1.8
--- modules/fnmatch     22 Jul 2005 19:30:39 -0000
***************
*** 21,27 ****
  
  # We need the following in order to create an <fnmatch.h> when the system
  # doesn't have one that supports the required API.
- all-local $(lib_OBJECTS): $(FNMATCH_H)
  fnmatch.h: fnmatch_.h
        cp $(srcdir)/fnmatch_.h address@hidden
        mv address@hidden $@
--- 21,26 ----
*** modules/getopt      6 Jul 2005 15:58:47 -0000       1.8
--- modules/getopt      22 Jul 2005 19:30:39 -0000
***************
*** 20,26 ****
  
  # We need the following in order to create an <getopt.h> when the system
  # doesn't have one that works with the given compiler.
- all-local $(lib_OBJECTS): $(GETOPT_H)
  getopt.h: getopt_.h
        cp $(srcdir)/getopt_.h address@hidden
        mv address@hidden $@
--- 20,25 ----
*** modules/glob        29 May 2005 16:56:02 -0000      1.1
--- modules/glob        22 Jul 2005 19:30:39 -0000
***************
*** 28,34 ****
  
  # We need the following in order to create an <glob.h> when the system
  # doesn't have one that works with the given compiler.
- all-local $(lib_OBJECTS): $(GLOB_H)
  glob.h: glob_.h
        cp $(srcdir)/glob_.h address@hidden
        mv address@hidden $@
--- 28,33 ----
*** modules/poll        22 Sep 2004 15:11:04 -0000      1.5
--- modules/poll        22 Jul 2005 19:30:39 -0000
***************
*** 17,23 ****
  
  # We need the following in order to create an <poll.h> when the system
  # doesn't have one.
- all-local $(lib_OBJECTS): $(POLL_H)
  poll.h: poll_.h
        cp $(srcdir)/poll_.h address@hidden
        mv address@hidden $@
--- 17,22 ----
*** modules/stdbool     22 Sep 2004 15:11:04 -0000      1.10
--- modules/stdbool     22 Jul 2005 19:30:39 -0000
***************
*** 17,23 ****
  
  # We need the following in order to create an <stdbool.h> when the system
  # doesn't have one that works.
- all-local $(lib_OBJECTS): $(STDBOOL_H)
  stdbool.h: stdbool_.h
        sed -e 's/@''HAVE__BOOL''@/$(HAVE__BOOL)/g' < $(srcdir)/stdbool_.h > 
address@hidden
        mv address@hidden $@
--- 17,22 ----
*** modules/stdint      17 Mar 2005 18:31:11 -0000      1.3
--- modules/stdint      22 Jul 2005 19:30:39 -0000
***************
*** 19,25 ****
  
  # We need the following in order to create an <stdint.h> when the system
  # doesn't have one that works with the given compiler.
- all-local $(lib_OBJECTS): $(STDINT_H)
  stdint.h: stdint_.h
        sed -e 
's/@''HAVE_LONG_64BIT''@/$(HAVE_LONG_64BIT)/g;s/@''HAVE_LONG_LONG_64BIT@/$(HAVE_LONG_LONG_64BIT)/g'
 < $(srcdir)/stdint_.h > address@hidden
        mv address@hidden $@
--- 19,24 ----
*** modules/sysexits    22 Sep 2004 15:11:04 -0000      1.4
--- modules/sysexits    22 Jul 2005 19:30:39 -0000
***************
*** 11,21 ****
  gl_SYSEXITS
  
  Makefile.am:
  EXTRA_DIST += sysexit_.h
  
  # We need the following in order to create a <sysexits.h> when the system
  # doesn't have one that works with the given compiler.
- all-local $(lib_OBJECTS): $(SYSEXITS_H)
  sysexits.h: sysexit_.h
        cp $(srcdir)/sysexit_.h sysexits.h-t
        mv sysexits.h-t sysexits.h
--- 11,21 ----
  gl_SYSEXITS
  
  Makefile.am:
+ BUILT_SOURCES += $(SYSEXITS_H)
  EXTRA_DIST += sysexit_.h
  
  # We need the following in order to create a <sysexits.h> when the system
  # doesn't have one that works with the given compiler.
  sysexits.h: sysexit_.h
        cp $(srcdir)/sysexit_.h sysexits.h-t
        mv sysexits.h-t sysexits.h