install-strip rule doesn't work

[Jim Meyering]

Hi Bob,

Thanks for reporting that.
It seems to be a bug that's still in the current sources.

In fileutils-4.1/src/Makefile, I see this:

  INSTALL_STRIP_PROGRAM = $${INSTALL} -s

which eventually expands to just ` -s' and produces the
symptom Bob noted below.

The problem comes from automake's m4/strip.m4.
We want the make variable, $(INSTALL) not the shell variable.
[I prefer parens to curly braces, but have left the braces,
 in case they're there for a good reason]

Here's a patch that should work:

2001-04-30  Jim Meyering  <address@hidden>

        * m4/strip.m4: Fix a typo: s/\$\$/$/.



--- m4/strip.m4.~1~     Mon Feb 19 05:11:57 2001
+++ m4/strip.m4 Mon Apr 30 11:13:36 2001
@@ -30,7 +30,7 @@ if test -z "$STRIP"; then
   # is substitued in the sub-makes, not at the top-level; this is
   # needed if ${INSTALL} is a relative path (ajusted in each subdirectory
   # by config.status).
-  INSTALL_STRIP_PROGRAM='$${INSTALL} -s'
+  INSTALL_STRIP_PROGRAM='${INSTALL} -s'
   INSTALL_STRIP_PROGRAM_ENV=''
 else
   _am_dirpart="`echo $install_sh | sed -e 's,//*[[^/]]*$,,'`"

Bob Proulx <address@hidden> wrote:
| Jim
...
| I just happened to try something new today.  I tried to use the newer
| make target install-strip that the later automake provides.  It seems
| broken.
|
|   make install-strip
|   /bin/sh ../mkinstalldirs /usr/local/bin
|     -s chgrp /usr/local/bin/chgrp
|   /bin/sh: -s:  not found.
|
| BTW, here is the previous method that I am continuing to use for
| production installations.
|
|   make INSTALL_PROGRAM='install -s' install
|
| This had not previously existed and so should not be a concern for
| the, well deserved, release.  But I did want to note it anyway.
|
| Bob