[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 64-simplify-handle-gettext.patch
From: |
Tom Tromey |
Subject: |
Re: 64-simplify-handle-gettext.patch |
Date: |
24 Feb 2001 20:55:53 -0700 |
>>>>> "Akim" == Akim Demaille <address@hidden> writes:
Akim> + &am_line_error ('SUBDIRS',
Akim> + "AM_GNU_GETTEXT used but \`po' not in SUBDIRS")
Akim> + if $contents{'SUBDIRS'} !~ /\bpo\b/;
Akim> + &am_line_error ('SUBDIRS',
Akim> + "AM_GNU_GETTEXT used but \`intl' not in SUBDIRS")
Akim> + if $contents{'SUBDIRS'} !~ /\bintl\b/;
This code -- and the old code, I admit -- is broken.
Random bits of code shouldn't look at $contents{...}.
Instead they have to use &variable_value or &variable_value_as_list.
That's because the variable might be conditionally defined.
Can you update the patch to do this? With that minor change it is ok.
Tom