[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: byte compilation in older emacs [patch]

From: Jim Meyering
Subject: Re: byte compilation in older emacs [patch]
Date: Fri, 3 Jan 2020 18:23:55 -0800

On Fri, Jan 3, 2020 at 6:13 PM Karl Berry <address@hidden> wrote:
> Sigh. I failed to note that vc-dwim did not dwim; my summary first line
> was once again not recognized. (And I guess I should update the date.)
> I'll figure that out before pushing, but anyway, the content of the
> patch is what really needs review. Here's the actual ChangeLog entry as
> written ... -k
> 2020-01-03  Karl Berry  <address@hidden>
>         automake: Support byte compilation in older Emacsen
>         * lib/am/ (am__emacs_byte_compile_setup) [FIRST]: define
>         new make variable, to use byte-compile-dest-file-function if
>         available, else byte-compile-dest-file.
>         (.el.elc): use it.
>         * t/ skip test if emacs version is <= 23,
>         since their -L ordering is backwards.
>         * NEWS: update.

Thank you for doing that. It looks fine to me. One request:

In this:
+emacs_major=$(${EMACS-emacs} --version | sed -e 's/.* //' -e 's/\..*$//' -e 1q)

please use this same-functionality sed command. I prefer to eliminate
such uses of -e and to reduce quote count:
  sed 's/.* //;s/\..*$//;1q'

reply via email to

[Prev in Thread] Current Thread [Next in Thread]