[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] python tests: Do not require .pyo files

From: Mathieu Lirzin
Subject: Re: [PATCH 2/2] python tests: Do not require .pyo files
Date: Sun, 08 Jul 2018 23:29:47 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Mathieu Lirzin <address@hidden> writes:

> Lukas Fleischer <address@hidden> writes:
>> On Sat, 07 Jul 2018 at 23:45:27, Mathieu Lirzin wrote:
>>> Lukas Fleischer <address@hidden> writes:
>>> > As of Python 3.5, but unoptimized and optimized bytecode are stored
>>> > within .pyc files; .pyo files are no longer generated. Update the Python
>>> > tests such that the test do not fail if .pyo files are missing.
>>> Like in other message, it is important that the test suite passes
>>> with older python version.  Have you checked?
>> Note that this patch only removes some checks, so after this patch,
>> everything is strictly less restrictive. I don't see how this could
>> possibly break backwards compatibility.
>> Nevertheless, I just made sure that everything still works with Python
>> 2.7.15.
> OK I overlooked that.  I think a inlined comment in the concerned tests
> explaining why python object files presence is not tested would help
> future code reader to understand.
> Can you send an updated patch?

Please forget the updated patch fornow.  I have just remember about
about bug#30556 [1] where test suite is known to fail when ‘python’ is
‘python3’ and not ‘python2’ which is the case on Arch Linux.  Sorry for
the confusion.

You seem to have a better understanding of how various version of python
handles compilation and caches than I do.  Maybe can you summarize (give
some pointers)  the various evolution in that regard?


Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

reply via email to

[Prev in Thread] Current Thread [Next in Thread]