[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] automake: avoid harmful directory change before invoking val

From: Stefano Lattarini
Subject: Re: [PATCH] automake: avoid harmful directory change before invoking valac
Date: Mon, 22 Dec 2014 12:05:00 +0100

On 12/22/2014 11:32 AM, Yanko Kaneti wrote:
On Fri, 2014-12-19 at 22:01 +0100, Stefano Lattarini wrote:
Hi, thanks for the patch, and sorry for the delay.

On 12/02/2014 02:22 PM, Yanko Kaneti wrote:
The current am__cd right before invoking valac invalidates
any relative flags setup done before that.
BTW, this was already reported as So
finally fixing it would likely be a good idea.

   bin/ | 3 ++-
   1 file changed, 2 insertions(+), 1 deletion(-)

Such a fix requires at least a new test case and a NEWS entry. Care
to take at stab at writing them?

I looked a bit in the t/ directory but my eyes glazed over.
Perhaps I am not the best person to attempt those.

It's OK if you can just post the snippets of relevant vala sources
and build options exposing the problem, and describe the steps to
reproduce such a problem.  I can synthesize a test case from there
myself then.

diff --git a/bin/ b/bin/
index 4cee0d0..3082207 100644
--- a/bin/
+++ b/bin/
@@ -5476,6 +5476,7 @@ sub lang_vala_finish_target
     my $silent = silent_flag ();
     my $stampfile = "\$(srcdir)/${derived}_vala.stamp";

+  map { !/^\// && ($_ = "\$(srcdir)\/" . $_) } @vala_sources;
What is the point of the "!/^\//" conditional?

The idea was to protect from mangling any vala_sources that might
already be absolute paths. If that's not expected or supported then it
can be dropped.

Indeed it is not expected to be supported.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]