Re: bug#14499: broken texi2dvi causes a FAIL in t/txinfo-no-split.sh

[Stefano Lattarini]

On 05/29/2013 08:33 AM, Peter Rosin wrote:
> Hi!
> 
> On MSYS, I have this situation:
> 
> $ texi2dvi --version
> You don't have a working TeX binary installed, but the texi2dvi script
> can't proceed without it. If you want to use this script, you have to
> install some kind of TeX, for example the MikTeX package from
> http://miktex.org/ (which is not part of the typical MSYS environment).
> $ echo $?
> 1
> 
> Which causes the below failure on master (baf8a1c22acce0908) in
> t/txinfo-no-split.sh.
> 
> Cheers,
> Peter
> 
> make[1]: Entering directory 
> `/c/Cygwin/home/peda/automake/t/txinfo-no-split.dir/txinfo-no-split-1.0/_build'
> TEXINPUTS="..:$TEXINPUTS" \
>       MAKEINFO='makeinfo --split-size 10   -I ..' \
>       texi2dvi  --build-dir=foo.t2d -o foo.dvi  \
>       ../foo.texi
> You don't have a working TeX binary installed, but the texi2dvi script
> can't proceed without it. If you want to use this script, you have to
> install some kind of TeX, for example the MikTeX package from
> http://miktex.org/ (which is not part of the typical MSYS environment).
> make[1]: *** [foo.dvi] Error 1
> make[1]: Leaving directory 
> `/c/Cygwin/home/peda/automake/t/txinfo-no-split.dir/txinfo-no-split-1.0/_build'
> 
> 

The patch below should fix the issue.   Can you confirm?

Thanks,
  Stefano

---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ----

>From 455d0f33b1540e75006cbf267cd7bda1a70eb5bc Mon Sep 17 00:00:00 2001
Message-Id: <address@hidden>
From: Stefano Lattarini <address@hidden>
Date: Wed, 29 May 2013 11:41:09 +0200
Subject: [PATCH] tests: avoid a spurious failure when TeX is not installed.

Fixes automake bug#14499.

* t/txinfo-no-split.sh: If TeX is not available, redefine 'dvi' to be a
dummy target, so that "make distcheck" doesn't fail while trying to build
the DVI version of the Texinfo manual.

Signed-off-by: Stefano Lattarini <address@hidden>
---
 t/txinfo-no-split.sh | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/t/txinfo-no-split.sh b/t/txinfo-no-split.sh
index aecf7e7..6a50f1c 100644
--- a/t/txinfo-no-split.sh
+++ b/t/txinfo-no-split.sh
@@ -34,6 +34,13 @@ check-local:
        test "`find $(srcdir) . | grep '\.info'`" = "$(srcdir)/foo.info"
 END

+# Systems lacking a working TeX installation cannot run "make dvi".
+if test -z "$TEX"; then
+  warn_ "TeX installation missing, \"make dvi\" will be skipped"
+  echo AUTOMAKE_OPTIONS = -Wno-override >> Makefile.am
+  echo 'dvi:; @echo Tex is missing, do nothing' >> Makefile.am
+fi
+
 cat > foo.texi << 'END'
 \input texinfo
 @setfilename foo.info
-- 
1.8.3.rc3.8.g5e49f30