Re: bug#14019: conditional tests and parallel test harness

[Stefano Lattarini]

tags 14019 + patch
close 14019
stop

On 04/21/2013 01:08 PM, Sven Verdoolaege wrote:
> On Sat, Apr 20, 2013 at 09:17:24PM +0200, Stefano Lattarini wrote:
>> On 03/20/2013 05:10 PM, Sven Verdoolaege wrote:
>>> Is it no longer allowed to have conditional tests as in
>>>
>>>     TESTS = @extra_tests@
>>>     EXTRA_TESTS = pet_test.sh
>>>
>>> or is anything missing from my input?
>>>
>> If you add "TEST_EXTENSIONS = .sh", everything should work again.
>> Can you confirm this is the case?
> 
> Thanks.  That fixes the problem.
> 
Thanks for confirming.  And the patch below fixes the documentation
issue.  I'm thus closing this report.

Regards,
  Stefano

---- 8< ---- 8<---- 8<---- 8<---- 8<---- 8<---- 8<---- 8<---- 8<---- 8< ----

>From 915bf025b0fcc35e19648126da66f12d68cf2633 Mon Sep 17 00:00:00 2001
Message-Id: <address@hidden>
From: Stefano Lattarini <address@hidden>
Date: Thu, 25 Apr 2013 21:03:40 +0200
Subject: [PATCH] docs: issues with configure substitutions in TESTS

Motivated by automake bug#14019.

* doc/automake.texi: Currently, when the parallel test harness is in use,
configure substitutions in TESTS definitions can only work if they expand
to tests that ends with a suffix listed in TEST_EXTENSIONS.  Document this
limitation.

Signed-off-by: Stefano Lattarini <address@hidden>
---
 doc/automake.texi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/automake.texi b/doc/automake.texi
index d420d28..f7a0a28 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -9099,6 +9099,12 @@ followed by any number of alphabetic characters.
 For example, @samp{.sh}, @samp{.T} and @samp{.t1} are valid extensions,
 while @samp{.x-y}, @samp{.6c} and @samp{.t.1} are not.

address@hidden Configure substitutions in @code{TESTS}
+It is important to note that, due to current limitations (unlikely to be
+lifted), configure substitutions in the definition of @code{TESTS} can
+only work if they will expand to a list of tests that have a suffix listed
+in @code{TEST_EXTENSIONS}.
+
 @vindex _LOG_COMPILE
 @vindex _LOG_COMPILER
 @vindex _LOG_FLAGS
-- 
1.8.2.1.610.g562af5b