Re: reinstate AM_PROG_MKDIR_P

[Stefano Lattarini]

Hi Jim.

On 10/25/2012 07:32 PM, Jim Meyering wrote:
> You wrote:
>> OK, if someone sends a patch reverting the AM_PROG_MKDIR_P removal (with a
>> rationale in the commit message), I'll take it.  But AM_PROG_MKDIR_P will
>> be dropped in 1.14, without further "ifs" or "buts".
> 
> Hi Stefano,
> 
> Here's the promised patch.
> This is relative to "master" and "make check" still passes.
>
Thanks.  The patch will be OK to go after one nit (see below) is
resolved.

But please note that I'm going to remove AM_PROG_MKDIR_P for good in
Automake 1.14, independently of what gettext does; so you might want
to put some pressure on that project to accept my pending patch that
makes it use AC_PROG_MKDIR_P instead of AM_PROG_MKDIR_P:

  <http://lists.gnu.org/archive/html/bug-gettext/2012-10/msg00001.html>

> I have spent too little time investigating the merge conflicts,
> so odds are good that you'll find more than nits to pick.
> 
> 
> From 0593ddfd6f6a2ed58aaa1aa7e0b361d4a5108924 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Mon, 22 Oct 2012 16:14:49 +0200
> Subject: [PATCH] reinstate AM_PROG_MKDIR_P
>
Feel free to ignore this, but: what about using the "compat" prefix for
the summary line, and giving few more details?  As in

    compat: reinstate AM_PROG_MKDIR_P, for gettext

> Do not remove AM_PROG_MKDIR_P just yet.
> 
> gettext (latest from git) still AC_REQUIRE's AM_PROG_MKDIR_P via its
> intl.m4 and po.m4 files, which are pulled into *many* projects.
> 
> When I try to build one of those projects (coreutils) using the latest
> from automake.git/master, I see this failure:
> 
>     $ aclocal -I m4
>     configure.ac:477: warning: AM_PROG_MKDIR_P is m4_require'd \
>       but not m4_defun'd
>     m4/po.m4:23: AM_PO_SUBDIRS is expanded from...
>     m4/gettext.m4:57: AM_GNU_GETTEXT is expanded from...
>     configure.ac:477: the top level
> 
> That is because AM_PROG_MKDIR_P was removed (via commit
> v1.12-20-g8a1c64f) in preparation for the next release of automake.
> 
> * NEWS: Remove the paragraph that announced the removal of
> AM_PROG_MKDIR_P.
> * Makefile.am (dist_automake_ac_DATA): Add m4/mkdirp.m4.
> * m4/mkdirp.m4: Re-add file.
> * t/mkdirp-deprecation.sh: Likewise.
> * t/list-of-tests.mk: Add it.
> * automake.in: Restore removed code, and adjust comments, s/1.13/1.14/
> to reflect new plan for removal.
> * doc/automake.texi (Obsolete Macros): Restore deleted section.
>
Could you please restore only the entry for AM_PROG_MKDIR_P, rather
than the entire section?  Thanks.

ACK with that addressed.

Regards,
  Stefano