[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[FYI] {maint} cleanup: remove almost-unused global var 'topsrcdir'
From: |
Stefano Lattarini |
Subject: |
[FYI] {maint} cleanup: remove almost-unused global var 'topsrcdir' |
Date: |
Fri, 10 Aug 2012 11:53:13 +0200 |
Cherry picked from commit v1.12.2-740-ga7f24eb in Automake-NG.
* automake.in ($topsrcdir): Delete, it was only used once ...
(handle_LIBOBJS_or_ALLOCA): ... in here, so it's simpler to inline
its expansion. Improve formatting of immediately surrounding code
a little while we are at it.
(initialize_per_input): Don't reset the deleted variable.
Signed-off-by: Stefano Lattarini <address@hidden>
---
automake.in | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/automake.in b/automake.in
index 1a94c04..d85d361 100644
--- a/automake.in
+++ b/automake.in
@@ -484,9 +484,6 @@ my $am_relative_dir;
my $in_file_name;
my $relative_dir;
-# Relative path to the top directory.
-my $topsrcdir;
-
# Greatest timestamp of the output's dependencies (excluding
# configure's dependencies).
my $output_deps_greatest_timestamp;
@@ -640,7 +637,6 @@ sub initialize_per_input ()
$in_file_name = undef;
$relative_dir = undef;
- $topsrcdir = undef;
$output_deps_greatest_timestamp = 0;
@@ -2309,8 +2305,10 @@ sub handle_LIBOBJS_or_ALLOCA ($)
# we are already there, and since the targets are built without
# a $(top_builddir), it helps BSD Make to match them with
# dependencies.
- $dir = "$config_libobj_dir/" if $config_libobj_dir ne '.';
- $dir = "$topsrcdir/$dir" if $relative_dir ne '.';
+ $dir = "$config_libobj_dir/"
+ if $config_libobj_dir ne '.';
+ $dir = backname ($relative_dir) . "/$dir"
+ if $relative_dir ne '.';
define_variable ('LIBOBJDIR', "$dir", INTERNAL);
$clean_files{"\$($var)"} = MOSTLY_CLEAN;
# If LTLIBOBJS is used, we must also clear LIBOBJS (which might
@@ -8111,7 +8109,6 @@ sub generate_makefile ($$)
$relative_dir = dirname ($makefile);
$am_relative_dir = dirname ($makefile_am);
- $topsrcdir = backname ($relative_dir);
read_main_am_file ($makefile_am);
if (handle_options)
--
1.7.12.rc0
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [FYI] {maint} cleanup: remove almost-unused global var 'topsrcdir',
Stefano Lattarini <=